Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fp32 issues with DS fork wheel for stable diffusion, fix llm tests #390

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

siddvenk
Copy link
Contributor

Description

  1. Fix issues with fp32 dtype for stable diffusion via deepspeed. There are 2 things that get fixed:
    • If dtype is not specified (i.e. None) when passed to ds init inference and replace_with_kernel_inject=True and replace_method='auto', then ds will invoke fp16 layers and fused kernels. If fp32 is specified with the same configurations otherwise, there will be an error due to not having fused kernels/layers to replace with (fp32 kernels for stable-diffusion layers are not implemented in ds 0.7.5)
    • In our fork with bf16, due to some logic changes about replacing layers, there is an error in the case dtype=None rather than silently failing and using fp16 like the original deepspeed behavior
    • Stable diffusion kernels for fp32, as well as some ops not being set for layer replacement seem to be partially fixed in 0.7.6, and actively being worked on for 0.7.7
  2. Fixes the issues with llm integration tests

@siddvenk siddvenk merged commit 606aac3 into deepjavalibrary:master Dec 12, 2022
@siddvenk siddvenk deleted the sd-test branch December 12, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants